Add per-particle neighbor loop (NoShifting / NoKernelOutput)#155
Open
AhmedSalih3d wants to merge 1 commit intomainfrom
Open
Add per-particle neighbor loop (NoShifting / NoKernelOutput)#155AhmedSalih3d wants to merge 1 commit intomainfrom
AhmedSalih3d wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
NeighborLoop!specialized forSimulationMetaData{..., NoShifting, NoKernelOutput, ...}that iterates per particle, partitions work into stable per-thread chunks, and accumulates contributions into per-thread buffers (SimThreadedArrays.dρdtIThreadedandAccelerationThreaded).ComputeInteractionsPerParticleNoKernel!which computes density-change and acceleration contributions between a particle pair but omits kernel-output and shifting side-effects, and returns the updated accumulators.SimParticles.Cells,ParticleRanges, andCellDictto lookup same-cell and neighbor-cell particle ranges and perform the full stencil neighbor traversal while skipping the center cell when iterating neighbors.src/SPHCellList.jl(new specializedNeighborLoop!andComputeInteractionsPerParticleNoKernel!).Testing
julia --project=. -e 'using Pkg; Pkg.test()', but the run did not complete because package precompilation (UnicodePlots) stalled and the process was interrupted, so the test suite did not finish successfully.Codex Task